New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent GOV.UK Frontend “already initialised” Tabs error #575

Merged

colinrotherham merged 1 commit into main from bug/466616-form-overview-tabs

Oct 31, 2024

Contributor

colinrotherham commented Oct 31, 2024

This PR fixes bug #466616

We were accidentally double-rendering the GOV.UK Frontend Tabs component

This is now thrown by govuk-frontend@5.7.0 since alphagov/govuk-frontend#5272


          Prevent GOV.UK Frontend “already initialised” Tabs error

aed8045

sonarcloud bot commented Oct 31, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Contributor Author

colinrotherham commented Oct 31, 2024

See guidance in React: Fixing bugs found by double rendering in development which might be useful

alexluckett approved these changes

View reviewed changes

colinrotherham merged commit b376525 into main

11 checks passed

colinrotherham deleted the bug/466616-form-overview-tabs branch

October 31, 2024 13:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet